Call for final changes for 2.2.3.

Jeremy Allison jra at samba.org
Sat Jan 19 13:30:36 GMT 2002


On Sat, Jan 19, 2002 at 02:40:47PM +0100, andreas moroder wrote:
> 
> static void smb_dump(char *name, int type, char *data, ssize_t len
> 
> there is a write with no check. There sould be a check that prints out a 
> debug line in case of failure.

Fixed thanks.

> there is also the asprintf question.  As I posted on Jan 14, there are many 
> places where the return value of asprintf is not checked. 
> 
> client/client.c at lines 1309, 1317, 1331, 1337
> 
> libsmb/domain_client_validate.c at line  348 **
> 
> nsswitch/winbindd_cm.c at line 716
> 
> rpcclient/cmd_spoolss.c at lines 1232, 1235

Fixed by Simo.

> There is also the "FreeBSD + samba 2.2.2 problems; semi-solution" problem
> We have a CVS version of samba 2.2.3 running on suse linux 7.2 that gives us 
> also oplock problems with a older clipper/dos application. The clients are 
> all win98 and 98se

I'm going to add this with an #ifdef FREEBSD_TCP_BUG define around it
as I don't want it in the mainline unless needed.

Thanks,

	Jeremy.




More information about the samba-technical mailing list