NamedPipe DCE/RPC struct split

Andrew Bartlett abartlet at pcug.org.au
Wed Jan 16 14:50:08 GMT 2002


Luke Kenneth Casson Leighton wrote:
> 
> third version.
> 
> this one contains a more-obvious split-out of read_data_outstanding()
> as well, as a separate patch.
> 
> comments included on the next stage which is to add dso capabilities.
> 
> put five functions into smb_np_struct to make it easier / obvious
> as to where / how to do that [make dso].
> 
> api_reply_trans really _does_ have to use namedpipe_transact
> and then namedpipe_read no longer needs that extra parameter.
> [see patch comments]
> 
> the only reason it's there is because smbd/ipc.c calls write,
> then read, then finds out if there is any more data outstanding,
> manually, when in fact that's namedpipe_transact's job.

MUCH better:  Thanks!.   I'll give this a good looking over, but you
have addressed most of this issues I had with the previous versions.

Andrew Bartlet

-- 
Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net




More information about the samba-technical mailing list