NamedPipe DCE/RPC struct split
abartlet at pcug.org.au
Tue Jan 15 09:12:25 GMT 2002
Luke Kenneth Casson Leighton wrote:
> hiya, second version.
> p->p removed. p->p->vuid removed. p->p->conn removed.
> unrelated cleanups of original code not included.
> andrew the cleanups do you think that should be done _before_
> or after?
The usual deal is:
Person wants functionality in samba. Current area is a bit of a mess.
Person gets to put in functionality, but must also do a bit to tidy up
That way we move forward both in quality and quanitity.
As the cleanups I was suggesting are farily minor, I think its pretty
fair. It also helps me with the overall 'this code has been looked at
with a good pair of eyes already' feeling when I go to review the patch.
Andrew Bartlett abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team abartlet at samba.org
Student Network Administrator, Hawker College abartlet at hawkerc.net
http://samba.org http://build.samba.org http://hawkerc.net
More information about the samba-technical