tdb_delete used as traversal function

Jeremy Allison jra at
Thu Jan 3 14:57:01 GMT 2002

On Thu, Jan 03, 2002 at 03:32:57PM -0600, Esh, Andrew wrote:
> Speaking from the standpoint of my C experience (I am not familiar with this
> specific code):
> Yes, the more obvious do_delete_fn function should be used.
> The current code is correct, however. The extra arguments will only consume
> some extra stack space, and will then be cleaned up when tdb_delete exits,
> and the stack frame is popped off.
> The current code will perform slightly better than do_delete_fn, however.

FYI - I just fixed this in HEAD and 2.2.3. It's always better to use
correct prototypes, due to possible problems with strange embedded
compilers that push/pop args in different ways.


More information about the samba-technical mailing list