smbclient -L is broken in SAMBA_2_2

Jeremy Allison jra at samba.org
Thu Jan 3 10:52:14 GMT 2002


On Thu, Jan 03, 2002 at 05:27:26PM +0200, Alexander Bokovoy wrote:
> Latest backport of source/libsmb/cli* stuff seems caused 
> broken smbclient -L work: it doesn't enumerate servers and workgroups.
> CVS HEAD works fine but SAMBA_2_2 does not. My search shows that
> 
> cli_api(cli, 
> 	param, PTR_DIFF(p,param), 8,        /* params, length, max */
>         NULL, 0, CLI_BUFFER_SIZE,	    /* data, length, max */
>         &rparam, &rprcnt,		    /* return params, return size */
>         &rdata, &rdrcnt			    /* return data, return size */
>        )
> 													    in source/libsmb/clirap.c:239 returns error code 2320 which isn't enumerated in 
> source/include/doserr.h and isn't expected in this function (cli_NetServerEnum) 
> where only 0 or ERRmoredata are expected.
> 
> This results in absent server and workgroup lists.

Thanks for that bug report. It was a bug in clistr_pull with src_len -1, UNICODE
set and src_len = -1 (not applicable to HEAD).

I've fixed it in CVS.

Thanks !

	Jeremy.




More information about the samba-technical mailing list