stdio in smbd

[Jeremy Allison]

On Tue, Feb 26, 2002 at 08:26:40AM -0500, David Collier-Brown wrote:
> Andy Polyakov wrote:
> > 
> . For further discussions and workarounds see "Proposed
> > patch for Samba-2.0.7 to allow Solaris open more than 1014 (or
> > rlim_fd_max) files" *thread* at
> > http://lists.samba.org/pipermail/samba-technical/2001-January/thread.html#27212.
> > I can only add that following is also essential:
> > 
> > *** lib/util.c.orig     Sat Oct 13 23:09:26 2001
> > --- lib/util.c  Thu Dec  6 01:47:44 2001
> > ***************
> > *** 1535,1540 ****
> > --- 1535,1543 ----
> >         if (rlp.rlim_max != RLIM_INFINITY) {
> >                 int orig_max = rlp.rlim_max;
> > 
> > +               if (requested_max > FD_SETSIZE)
> > +                       requested_max = FD_SETSIZE;
> > +
> >                 if ( rlp.rlim_max < requested_max )
> >                         rlp.rlim_max = requested_max;
> > 
> > A.
> 
> 
> 	Ok folks, can we get this diagnosis
> 	verified and checked in, then?

No, this is a bad fix for anything but Solaris I'm
afraid. We don't want to limit requested_max to FD_SETSIZE
which is quite small.

Jeremy.