idra at samba.org
Sun Feb 24 12:42:01 GMT 2002
It depends, if those bitmap need to live all the smbd process lifetime, than it is ok.
I have not looked at the code, I was against acnv_uxu2 deletion...
On Sun, Feb 24, 2002 at 06:53:54PM +0100, Claudia Moroder wrote:
> Hello Simo,
> it's ok not to delete this functions, but what about the memory leak ?
> I don't aksed to delete bifmap_free, I would like to know if it is ok that
> the memory is never freed ?
> -----Ursprüngliche Nachricht-----
> Von: "Simo Sorce" <idra at samba.org>
> An: "andreas moroder" <claudiamoroder at st-ulrich.suedtirol.net>
> Cc: <samba-technical at lists.samba.org>
> Gesendet: Sonntag, 24. Februar 2002 16:05
> Betreff: Re: memory leak
> > On Sun, Feb 24, 2002 at 02:56:16PM +0100, andreas moroder wrote:
> > > Hello
> > >
> > > bitmaps are allocated in samba with bitmap_allocate. The function
> > > is NEVER called.
> > >
> > > There are other functions in samba that are never used
> > >
> > > lib/charcnv.c acnv_u2ux
> > > lib/util_str.c smb_ucs2_t *all_string_sub_wa
> > I've added the last two recently and they are made to ease unicode
> > While not used at the moment, they will be when unicode will be more
> supported internally. (eg. acnv_uxu2 IS used).
> > Do NOT delete them!
> > > libsmb/asn1.c asn1_read_Integer(ASN1_DATA *data, int *i)
> > >
> > > What about to delete them ?
> > We should delete only unuseful(or harmful) code, not unused code.
> > Simo.
> > --
> > Simo Sorce idra at samba.org
> > -------------------------------
> > Samba Team http://www.samba.org
Simo Sorce idra at samba.org
Samba Team http://www.samba.org
More information about the samba-technical