idra at samba.org
Sun Feb 24 07:06:51 GMT 2002
On Sun, Feb 24, 2002 at 02:56:16PM +0100, andreas moroder wrote:
> bitmaps are allocated in samba with bitmap_allocate. The function bitmap_free
> is NEVER called.
> There are other functions in samba that are never used
> lib/charcnv.c acnv_u2ux
> lib/util_str.c smb_ucs2_t *all_string_sub_wa
I've added the last two recently and they are made to ease unicode traslation.
While not used at the moment, they will be when unicode will be more supported internally. (eg. acnv_uxu2 IS used).
Do NOT delete them!
> libsmb/asn1.c asn1_read_Integer(ASN1_DATA *data, int *i)
> What about to delete them ?
We should delete only unuseful(or harmful) code, not unused code.
Simo Sorce idra at samba.org
Samba Team http://www.samba.org
More information about the samba-technical