[PATCH] cannot join domain

Michael Steffens michael_steffens at hp.com
Fri Feb 15 03:30:04 GMT 2002


Hi,

in smbpasswd.c the call of charset_initialise() must
precede process_options(), because the latter one is
using strupper() for the "-j" argument.

In the current calling order one can't join any domain,
because new_domain will be nullified.

Cheers!
Michael
-------------- next part --------------
Index: source/utils/smbpasswd.c
===================================================================
RCS file: /cvsroot/samba/source/utils/smbpasswd.c,v
retrieving revision 1.93.2.28
diff -u -w -r1.93.2.28 smbpasswd.c
--- source/utils/smbpasswd.c	15 Feb 2002 00:31:27 -0000	1.93.2.28
+++ source/utils/smbpasswd.c	15 Feb 2002 11:24:00 -0000
@@ -975,12 +975,12 @@
 	set_auth_parameters(argc, argv);
 #endif /* HAVE_SET_AUTH_PARAMETERS */
 
+	charset_initialise();
+
 	process_options(argc, argv, amroot);
 	TimeInit();
 	
 	setup_logging("smbpasswd", True);
-	
-	charset_initialise();
 	
 	if(!initialize_password_db(False)) {
 		fprintf(stderr, "Can't setup password database vectors.\n");


More information about the samba-technical mailing list