[BUG] typo in winbindd

Alexander Bokovoy a.bokovoy at sam-solutions.net
Wed Feb 6 11:38:04 GMT 2002


On Wed, Feb 06, 2002 at 05:50:29PM +0100, dom at idealx.com wrote:
> Hello list,
> 
> The following patch fixes a typo in winbind (Samba 2.2.2 as released
> on 2001-10-13). The effect of the typo is quite weird - especially
> when a braindamaged Windoze advertises 255.255.255.255 as its
> broadcast address ! (BTW, why doesn't winbind use the "password
> server" parameter in smb.conf, instead of broadcast-then-pick-one ?)
> 
> Oh, and while I am at it, kudos to you all for job! Samba is one of
> the most active open-source projects these days, and you have been
> making really huge progresses lately. Keep up the good work!
> 
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> 
> diff -r -U3 samba-2.2.2-orig/source/nsswitch/winbindd_util.c samba-2.2.2/source/nsswitch/winbindd_util.c
> --- samba-2.2.2-orig/source/nsswitch/winbindd_util.c	Sat Oct 13 23:09:30 2001
> +++ samba-2.2.2/source/nsswitch/winbindd_util.c	Mon Feb  4 10:55:05 2002
> @@ -316,7 +316,7 @@
>  	   of our interfaces. */
>  	
>  	for (i = 0; i < count; i++) {
> -		if(!is_local_net(ip_list[i]))
> +		if(is_local_net(ip_list[i]))
>  			goto got_ip;
>  	}
> 
Already fixed in 2.2.3 release.
-- 
/ Alexander Bokovoy
Software architect and analyst             // SaM-Solutions Ltd.
---
Ducks?  What ducks??




More information about the samba-technical mailing list