leak of some sort in smbcacls

[Ronan Waide]

Hi,

just spotted this while leafing through the CVS tree (some code elided
for clarity)

source/utils/smbcacls.c

static int cacl_dump(struct cli_state *cli, char *filename)
{
[-]
    fnum = cli_nt_create(cli, filename, CREATE_ACCESS_READ);
[-]
    if (!sd) {
        printf("ERROR: secdesc query failed: %s\n", cli_errstr(cli));
        return EXIT_FAILED;
    }
[-]
    cli_close(cli, fnum);
[-]
}


So basically, cli_close doesn't get called for fnum if the security
descriptor (sd) is null. Since smbacls appears to be designed for one
file at a time right now, this probably isn't a major issue.

Cheers,
Waider.
-- 
waider at waider.ie / Yes, it /is/ very personal of me.
"Anyone who doesn't meet these standards will be cast into the outer darkness,
 where there is not only wailing and gnashing of teeth, but squishy mud and
 frogs that go 'ribbit'." - joshua geller