Code improvment in printing area.

jra at dp.samba.org jra at dp.samba.org
Fri Dec 6 21:53:01 GMT 2002


On Wed, Dec 04, 2002 at 02:00:44PM -0800, Arcady Chernyak wrote:
> Hi.
> I suggest the following small SAMBA code improvement in printing area.
>  
> All known SAMBA versions can't return to Windows client any return code
> after calling "print command".
> I need it therefore I made the following SAMBA changes:
>  
> 1.	Change prototype of function "print_job_end" (in file "proto.h"):
> int print_job_end(int jobid, BOOL normal_close);
> 2.	Add new error into file "doserr.h"
> #define ERRfiledeleted 63 /* Your file waiting to be printed was deleted.
> */
> I try to use this code in case of errors happened before calling "print
> command"
> 3.	Change function "print_job_end" in file "printing.c": 

This code change looks pretty good - thanks ! I'll try and adapt it
for inclusion in Samba 3.0.

Thanks,

	Jeremy.



More information about the samba-technical mailing list