[PATCH] allow cross-compiling samba-2.2.7

Dan Kegel dank at kegel.com
Fri Dec 6 18:03:00 GMT 2002

Steve Langasek wrote:
> On Fri, Dec 06, 2002 at 07:29:52AM -0800, Dan Kegel wrote:
>>Here's a patch that removes the one use of AC_TRY_RUN in configure.in
>>that was causing trouble.  (And oddly, this makes the definition of
>>HAVE_GETTIMEOFDAY_TZ better match how this macro is used in the sources,
>>I think.)  Please apply if you agree it's benign.  Thanks!
> Are you certain that the runtime check isn't needed on some platforms?
> There may be some platforms that appear to have a working gettimeofday()
> until you actually try to *use* it; maybe the AC_TRY_RUN was frivolous,
> but maybe it was added to deal with a real problem. 

Here's the only use of HAVE_GETTIMEOFDAY_TZ:

void GetTimeOfDay(struct timeval *tval)

Thus all it's trying to do is tell whether the 2nd parameter
has to be there.  You can do that without a runtime check --
unless you're trying to be sneaky and optimize away one
parameter for performance reasons.

If the group feels that there's an important performance reason
to avoid that 2nd parameter, then sure, I can submit another
patch that keeps the current "skip the 2nd parameter if it
didn't crash the first time we called it with only 1 parameter" behavior.

- Dan

More information about the samba-technical mailing list