New sam system
abartlet at samba.org
Sat Aug 10 13:58:00 GMT 2002
Kai Krueger wrote:
> ----- Original Message -----
> From: "Andrew Bartlett" <abartlet at samba.org>
> Sent: Thursday, August 01, 2002 1:09 AM
> > Kai Krueger wrote:
> > > P.S. perhaps adding const all along would make it clear which parameters
> > > "in parameters" and which are "out paramters"
> > Yes, that would be a very good idea.
> The appended patch adds const to all base function parameters that are "in"
> parameters. The parameters without const are therefore "out". The exception
> to this rule are the handles. In some functions the handles are "in"
> parameters and not changed to the callers point of view but still do not
> have const. This is because they might be changed internally (depending on
> the way those handles are implemented :-).
> In addition, I've started to add comments to all base functions. A lot of
> the function names are self explanatory, but I think some actually did
> profit of being explained :-)
Can you redo that patch so it applies to the copy in source/sam/ ?
Also, there are a few stray CRs in there...
Andrew Bartlett abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team abartlet at samba.org
Student Network Administrator, Hawker College abartlet at hawkerc.net
http://samba.org http://build.samba.org http://hawkerc.net
More information about the samba-technical