[PATCH] fix bug in lpq parsing

Jeremy Allison jra at samba.org
Fri Apr 19 10:19:02 GMT 2002

On Fri, Apr 19, 2002 at 05:32:24PM +1000, Martin Pool wrote:
> This patch merges some missing code from on APPLIANCE_HEAD
> into head, fixing a bug in the parser for lpq output.  
> Basically we're trying to concatenate several fields into a single
> string, but the calculation of the amount of space remaining is wrong.
> This causes a crash when there are a lot of fields in the output,
> because a negative value can be passed as the length parameter to
> safe_strcat.
> This was originally HP Nautilus CR #430.
> Please let me know if it's OK.

Looks good to me - I'll apply to HEAD and 2.2.4 if you haven't already...


More information about the samba-technical mailing list