Why are all UNISTR2s at least MAX_BUFFERLEN long?

Andrew Bartlett abartlet at pcug.org.au
Sat Apr 13 05:30:02 GMT 2002


I'm trying to figure out the logic behind this patch:

http://cvs.samba.org/cgi-bin/cvsweb/samba/source/rpc_parse/parse_misc.c.diff?r1=1.60&r2=1.61&f=h

and the mimimum size of all UNISTR2 structures it imposes?

Was this a simply typo (it looks like one) or is it becouse some areas
of the code (used to?) assume static buffers that were a particular
length?

In that case, who is writing to those strings?  My impression is that
they are 'read-only', and that most of the code pulls them into 'unix'
strings before messing with them.

Andrew Bartlett
-- 
Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net




More information about the samba-technical mailing list