Ignored return values
Simo Sorce
idra at samba.org
Sun Apr 7 15:07:02 GMT 2002
Hi Andreas, I've checked into HEAD some code to address this problem,
can you check it out and tell me if I missed anything?
Thank you.
On Sun, 2002-04-07 at 10:42, andreas moroder wrote:
> Hello Simo,
>
> as I told you in my recent e-mail, there are many functions calls where the
> return value is ignored.
> Here a list of the calls in tdb.c. Even in this file, it's not a simple tool
> or so, it's a part of samba's core, there are two close() functions where
> the return value is not checked.
>
> Bye
> Andreas
>
> tdb/tdb.c:94:3: Return value (type int) ignored: munmap(tdb->map_...
> tdb/tdb.c:239:4: Return value (type int) ignored: tdb_spinunlock(t...
> tdb/tdb.c:241:4: Return value (type int) ignored: tdb_brlock(tdb, ...
> tdb/tdb.c:443:2: Return value (type int) ignored: tdb_lock(tdb, i, 1)
> tdb/tdb.c:475:2: Return value (type int) ignored: tdb_lock(tdb, -1, 1)
> tdb/tdb.c:537:2: Return value (type int) ignored: update_tailer(td...
> tdb/tdb.c:681:2: Return value (type int) ignored: tdb_oob(tdb, tdb...
> tdb/tdb.c:1080:2: Return value (type int) ignored: write_unlock_rec...
> tdb/tdb.c:1123:4: Return value (type int) ignored: unlock_record(td...
> tdb/tdb.c:1140:5: Return value (type int) ignored: lock_record(tdb,...
> tdb/tdb.c:1146:4: Return value (type int) ignored: do_delete(tdb, c...
> tdb/tdb.c:1188:4: Return value (type int) ignored: unlock_record(td...
> tdb/tdb.c:1200:4: Return value (type int) ignored: unlock_record(td...
> tdb/tdb.c:1221:2: Return value (type int) ignored: unlock_record(td...
> tdb/tdb.c:1250:4: Return value (type int) ignored: unlock_record(td...
> tdb/tdb.c:1264:3: Return value (type int) ignored: lock_record(tdb,...
> tdb/tdb.c:1336:3: Return value (type int) ignored: tdb_delete(tdb, key)
> tdb/tdb.c:1450:3: Return value (type int) ignored: tdb_new_database...
> tdb/tdb.c:1527:4: Return value (type int) ignored: tdb_clear_spinlo...
> tdb/tdb.c:1563:3: Return value (type int) ignored: close(tdb->fd)
> tdb/tdb.c:1704:2: Return value (type int) ignored: close(tdb->fd)
> tdb/tdb.c:1710:2: Return value (type int) ignored: fstat(tdb->fd, &st)
> tdb/tdb.c:1724:2: Return value (type int) ignored: tdb_close(tdb)
--
Simo Sorce
----------
Una scelta di liberta': Software Libero.
A choice of freedom: Free Software.
http://www.softwarelibero.it
More information about the samba-technical
mailing list