VFS recycle bin

[Rainer Link]

Juergen Hasch schrieb:

[..]

> The recycle bin can be configured with the file /etc/samba/recycle_bin.conf:
> [ recycle bin ]
> name = .recycle
> maxsize = 100000
> exclude = .tmp.temp.o
> excludedir = /tmp/temp/
> 
> It's hardcoded for now because vfs_option doesn't seem to be implemented.

Hum, vfs options seems to be implemented in 2.4.4-pre. But, actually, it
seems the current code can handle only one vfs options entry, i.e.

    vfs object = /usr/local/samba/lib/vscan-sophos.so
    vfs options = abc = 123
    vfs options = yxz = 321

I only get "xyz = 321", even if I call lp_vfs_options(SNUM(conn)) twice.
But probably I do sth wrong?


> I have a question to the VFS experts. When I try to use
> the function default_vfs_ops.stat() smbd crashes, so I am
> using stat() directly. Why is this, especially because I have a
> simpler version of the recycle bin where it works ?

Hum, I can confirm this. I've used stat() in the past and switched to
default_vfs_ops.stat(). That's why I use stat() now again. 

Here's a snippet of log.smbd. If you need more details, just ask :-)
[2002/04/07 13:03:31, 10] lib/util.c:dump_data(1531)
  [000] 5C 6D 6F 64 75 6C 65 73  2E 63 6F 6E 66 00        \modules
.conf.
[2002/04/07 13:03:31, 3] smbd/process.c:switch_message(673)
  switch message SMBopenX (pid 1383)
[2002/04/07 13:03:31, 4] smbd/uid.c:change_to_user(118)
  change_to_user: Skipping user change - already user
[2002/04/07 13:03:31, 5] smbd/filename.c:unix_convert(145)
  unix_convert called on file "\modules.conf"
[2002/04/07 13:03:31, 3] lib/util.c:unix_clean_name(387)
  unix_clean_name [/modules.conf]
[2002/04/07 13:03:31, 5] smbd/mangle.c:is_8_3(337)
  Checking modules.conf for 8.3
[2002/04/07 13:03:31, 5] smbd/statcache.c:stat_cache_add(132)
  stat_cache_add: Added entry MODULES.CONF -> modules.conf
[2002/04/07 13:03:31, 5] smbd/filename.c:unix_convert(215)
  conversion finished modules.conf -> modules.conf
[2002/04/07 13:03:31, 3] smbd/dosmode.c:unix_mode(111)
  unix_mode(modules.conf) returning 0744
[2002/04/07 13:03:31, 5] smbd/files.c:file_new(121)
  allocated file structure 9832, fnum = 13928 (1 used)
[2002/04/07 13:03:31, 10] smbd/open.c:open_file_shared1(740)
  open_file_shared: fname = modules.conf, share_mode = 40, ofun = 1,
mode = 744, oplock requ
[2002/04/07 13:03:31, 8] lib/util.c:is_in_path(1143)
  is_in_path: modules.conf
[2002/04/07 13:03:31, 8] lib/util.c:is_in_path(1148)
  is_in_path: no name list.
[2002/04/07 13:03:31, 3] lib/util.c:unix_clean_name(387)
  unix_clean_name [modules.conf]
[2002/04/07 13:03:31, 4] smbd/open.c:open_file_shared1(888)
  calling open_file with flags=0x0 flags2=0x0 mode=0744
[2002/04/07 13:03:31, 10] smbd/open.c:fd_open(53)
[2002/04/07 13:03:31, 0] lib/fault.c:fault_report(38)
  ===============================================================
[2002/04/07 13:03:31, 0] lib/fault.c:fault_report(39)
  INTERNAL ERROR: Signal 11 in pid 1383 (2.2.4-pre)
  Please read the file BUGS.txt in the distribution
[2002/04/07 13:03:31, 0] lib/fault.c:fault_report(41)
  ===============================================================
[2002/04/07 13:03:31, 0] lib/util.c:smb_panic(1092)
  PANIC: internal error

stracing smbd (strace -p <smbd-parent> -ff -o <file>) doesn't show that
much detail.
strace log snippet from parent shows:
[..]
stat64("/usr/local/samba/lib/smb.conf", {st_mode=S_IFREG|0644,
st_size=2175, ...}) = 0
accept(9, {sin_family=AF_INET, sin_port=htons(32911),
sin_addr=inet_addr("127.0.0.1")}}, [16]) = 12
fork()                                  = 1411
close(12)                               = 0
select(1024, [9 10], NULL, NULL, NULL)  = ? ERESTARTNOHAND (To be
restarted)
--- SIGCHLD (Child exited) ---
wait4(-1, NULL, WNOHANG, NULL)          = 1411
wait4(-1, NULL, WNOHANG, NULL)          = -1 ECHILD (No child processes)
sigreturn()                             = ? (mask now [FPE USR2 PIPE])
select(1024, [9 10], NULL, NULL, NULL

strace log snippet from child omitted, it doesn't provide any helpful
information imho.


best regards,
Rainer Link

-- 
Rainer Link  | Member of Virus Help Munich (www.vhm.haitec.de)           
link at suse.de | Member of AMaViS Development Team (amavis.org)     
rainer.w3.to | OpenAntiVirus Project (www.openantivirus.org)