printcap name = cups doesn't work

[samba-technical at thewrittenword.com]

On Fri, Sep 28, 2001 at 01:31:55PM -0400, Michael Sweet wrote:
> Jeremy Allison wrote:
> > 
> > On Fri, Sep 28, 2001 at 01:08:02PM -0400, Michael Sweet wrote:
> > > "Gerald (Jerry) Carter" wrote:
> > > >
> > > > On Fri, 28 Sep 2001, Michael Sweet wrote:
> > > >
> > > > >     printing = cups
> > > > >     printcap name = cups
> > > >
> > > > IIRC the "printing = cups" is for parsing the output from
> > > > the "lpq command".  The "printcap name = cups" should
> > > > be all that is necessary for loading a lit of printers.
> > >
> > > OK, there is a bug in the configure.in file; attached is a patch to
> > > make the CUPS test work... (HAVE_CUPS wasn't getting defined... :)
> > 
> > Michael,
> > 
> >         Any chance of sending that as a diff -u, rather than
> > the entire configure.in file :-).
> 
> Ooops!  Clicked on the wrong file... :(
> 
> -- 
> ______________________________________________________________________
> Michael Sweet, Easy Software Products                  mike at easysw.com
> Printing Software for UNIX                       http://www.easysw.com
> Index: configure.in
> ===================================================================
> RCS file: /cvsroot/samba/source/configure.in,v
> retrieving revision 1.130.4.81
> diff -u -r1.130.4.81 configure.in
> --- configure.in	27 Sep 2001 03:56:57 -0000	1.130.4.81
> +++ configure.in	28 Sep 2001 16:59:55 -0000
> @@ -412,8 +412,8 @@
>  
>  if test x"$ac_cv_lib_cups_httpConnect" = x"yes"; then
>          AC_CHECK_HEADERS(cups/cups.h cups/language.h)
> -        if x"$ac_cv_header_cups_cups_h" = x"yes"; then
> -                if x"$ac_cv_header_cups_language_h" = x"yes"; then
> +        if test x"$ac_cv_header_cups_cups_h" = x"yes"; then
> +                if test x"$ac_cv_header_cups_language_h" = x"yes"; then
>                          AC_DEFINE(HAVE_CUPS)
>                  fi
>          fi

I always dislike the use of the internal autoconf names. Why not:
  AC_CHECK_HEADER(cups/cups.h,
      AC_CHECK_HEADER(cups/language.h,
          AC_DEFINE_UNQUOTED([HAVE_CUPS], ,
          [Define if you have CUPS])))

or even (ick):
  if test x"$ac_cv_header_cups_cups_h" = x"yes" -a \
     test x"$ac_cv_header_cups_language_h" = x"yes"; then
     AC_DEFINE(HAVE_CUPS)
  fi

The AC_DEFINE_UNQUOTED means one less entry in acconfig.h!

-- 
albert chin (china at thewrittenword.com)