small bitmap.c patch

Jeremy Allison jra at
Sat Sep 22 13:19:02 GMT 2001

On Sat, Sep 22, 2001 at 12:43:10PM -0700, Simo Sorce wrote:

> Well, I think this is not the case, but anyways the patch proposed,
> is not very good.
> It assumes the compiler will use the structure as it is declared,
> but optimization can change this, it can reorder datafor speed or
> memory optimization.
> Here it is a patch that should issue this problem and also use only
> one malloc.
> I've not yet committed it to the branch, if jeremy or andrew are ok
> with this kind of patch I will commit it.

I'm just not sure we need this patch to be honest.

Is there a problem with the current bitmap code ? Is it a
performance bottleneck ? I don't think so, and it currently
is better for automated tool checking.

My vote is just leave it alone unless someone can demonstrate
a problem.


More information about the samba-technical mailing list