rewrite of talloc with double linked lists
Gerald Carter
gcarter at valinux.com
Mon Sep 3 18:57:20 GMT 2001
On Mon, 3 Sep 2001, Christopher R. Hertel wrote:
> > Hello,
> >
> > after my first attempt to rewrite talloc.c that has never appeared in the
> > cvs, now I try it a second time. This time I use double linked lists to speed
> > up talloc_realloc.
> >
> > In the original code if you wanted to realloc memory, talloc_realloc did loop
> > through the list to find the memory item you wanted to realloc. Now this loop
> > is not necessary and the speed of talloc_realloc does not depend of the size
> > of the list.
> >
> > Here my diff against talloc.c and talloc.h of samba 2.2.1a
>
>
> Samba has two standard doubly-linked list utilities built in. It
> *looks* (from my initial once-over) as though your code does its own
> linked list handling. Could you take a look at includes/dlinklist.h
> and ubiqx/ubi_dLinkList? One of these should suit the need. It's
> just that using the same code means that small bugs and such
> (particularly those introduced when someone fiddles with the code
> later on) are easier to track down.
Andreas,
Someone will follow up on this patch soon. If you have not heard
back from me (or Jeremy or Tridge), send me mail directory to
jerry at samba.org to make sure it didn't get lost in my mailbox.
ok?
Thanks,
cheers, jerry
---------------------------------------------------------------------
www.samba.org SAMBA Team jerry_at_samba.org
www.plainjoe.org jerry_at_plainjoe.org
--"I never saved anything for the swim back." Ethan Hawk in Gattaca--
More information about the samba-technical
mailing list