Patch proposal

Jeremy Allison jra at samba.org
Fri Oct 26 08:43:05 GMT 2001


On Fri, Oct 26, 2001 at 10:35:00AM +0200, Tom Jansen wrote:
> Hi Jeremy,
> 
> cc to Richard Sharpe and samba-technical
> 
> [snip patch head] 
> > > >+    ret = send(fd,buffer + total,N - total, MSG_NOSIGNAL);
> [snip patch tail]
> 
> > I don't think this is a valid patch. I believe MSG_NOSIGNAL is non-portable.
> > Please don't apply this as it will break the build on all but Linux.
> 
> >From the manpage:
> 
> -- quote --
> CONFORMING TO
>        4.4BSD,  SVr4,  POSIX  1003.1g draft (these function calls
>        appeared in 4.2BSD).
> 
>        MSG_CONFIRM is a Linux extension.
> -- end quote --
> 
> 
> So MSG_NOSIGNAL is a POSIX flag. Unfortunately I do not have any other OSes to
> test on. If you are really sure it isn't possible please tell me and I will try
> to fix it using another workaround.

No it doesn't mean that. It means that the send call is POSIX conformant.
The flags fields are definately non-standard.

Jeremy.




More information about the samba-technical mailing list