code triplication

andreas moroder claudiamoroder at st-ulrich.suedtirol.net
Sat Oct 13 03:14:02 GMT 2001


Hello,

in the HEAD sources i found 3 times nearly identical code regarding 
credentials.

In clinet/smbmount.c 	read_credential_file
in rpcclient/rpcclient.c        read_authfile
in client/client.c		in main the case 'A'

The purpose of the 3 routines is allways the same and the code differences 
are very small ( use of x_ file functions and strchr_m ).

Is there a reason for this triplications ? Would it not be better to have one 
common function ?

Bye

Andreas Moroder




More information about the samba-technical mailing list