Samba 2.2.2 problem in lib/sprintf.c

Orwig, Paul PORWIG at PacificLife.com
Tue Nov 27 09:16:05 GMT 2001


Hmmm...
My suggestion was based on the compile failing due to a previous definition
of the routine.
Perhaps this has been corrected??

Paul

-----Original Message-----
From: Andrew Tridgell [mailto:tridge at samba.org]
Sent: Monday, November 26, 2001 9:01 PM
To: jra at samba.org
Cc: PORWIG at PacificLife.com; samba-technical at lists.samba.org
Subject: Re: Samba 2.2.2 problem in lib/sprintf.c


> > The original code uses OR ( || ) and caused the new vsnprintf and
snprintf
> > routines to be added despite being 
> > defined previously.
>
> Looks good - thanks !

no, the original code was correct. The patch breaks Samba on LOTS of
platforms.

The logic is that we want to do our own *snprintf() code if either the
system doesn't have it OR the systems one is broken. 

comment added ...




More information about the samba-technical mailing list