A little patch to smbgroupedit.c and mapping.c

[Simo Sorce]

Is the group support activated by default?
I can't see the groups I've created when watching to add permissions to
files in winnt4 (I see only Domain Admins & Domain Users groups)

why a default_group_mapping() call is done at every run of smbgroupedit
code?
isn't it better to integrate pdbedit and smbgroupedit in a single utility?

Index: utils/smbgroupedit.c
===================================================================
RCS file: /cvsroot/samba/source/utils/smbgroupedit.c,v
retrieving revision 1.2
diff -r1.2 smbgroupedit.c
3,4c3,4
<  *  Version 1.9.
<  *  RPC Pipe client / server routines
---
>  *  Version 3.0
>  *  Samba Groups editing utility
46a47
>       printf("  -v                   list groups\n");
50,51c51,57
<       printf("  -v                   list groups\n");
<       printf("  -c SID             change group\n");
---
>       printf("    -d description     Group description string\n");
>       printf("    -t[b|d|l]          type: builtin, domain, local \n");
>       printf("  -c SID               change group\n");
>       printf("    -u group           unix group name\n");
>       printf("    -n group           NT group name\n");
>       printf("    -p privilege       only local\n");
>       printf("    -d description     Group description string\n");
54d59
<       printf("    -t[b|d|l]          type: builtin, domain, local \n");
69,71c74,78
< /*    convert_priv_from_text(&se_priv, privilege);*/
<
<       se_priv=0xff;
---
>       if (privilege)
>               convert_priv_from_text(&se_priv, privilege);
>       else
>       /* By default build group with no priviledges */
>               se_priv=SE_PRIV_NONE;



Index: groupdb/mapping.c
===================================================================
RCS file: /cvsroot/samba/source/groupdb/mapping.c,v
retrieving revision 1.2
diff -r1.2 mapping.c
3,4c3,4
<  *  Version 1.9.
<  *  RPC Pipe client / server routines
---
>  *  Version 3.0.
>  *  Samba group mapping routines
249c249
< return the sid and the type of the unix group
---
> return the type of the unix group from SID
285c285
< return the sid and the type of the unix group
---
> return the sid and the type of the unix group from GID
322c322
< return the sid and the type of the unix group
---
> return the sid and the type of the unix group from NT group name
360c360
< enumerate the group mapping
---
> remove a group
510,511c510,512
< /* get a domain group from it's SID */
<
---
>
/****************************************************************************
> get a domain group from it's SID
>
****************************************************************************/
534,535c535,537
< /* get a local (alias) group from it's SID */
<
---
>
/****************************************************************************
> get a local (alias) group from it's SID
>
****************************************************************************/
572,574c574,576
<
< /* get a builtin group from it's SID */
<
---
>
/****************************************************************************
> get a builtin group from it's SID
>
****************************************************************************/
718c720
<  Create a UNIX group on demand.
---
>  Add a UNIX user to a UNIX group on demand.
736c738
<  Delete a UNIX group on demand.
---
>  Delete a UNIX user from a UNIX group on demand.



-- 
Simo Sorce - Linux Systems Consultant
E-mail: simo.sorce at polimi.it
Tel: +39 0348 7149179 - Fax: +39 02 700442399
-----------------------------------------------------------------
Be happy, use Linux!