User Manager for Domains on Win9x

Jeremy Allison jeremy at
Wed Mar 14 01:10:29 GMT 2001

On Wed, Mar 14, 2001 at 10:42:06AM +1100, Andrew Tridgell wrote:
> Please be careful with code like the following:
> > +		} else {
> > +			SIVAL(outbuf, smb_flg2, FLAGS2_32_BIT_ERROR_CODES);
> > +			SIVAL(outbuf, smb_rcls, 0x80000000 | STATUS_BUFFER_OVERFLOW);
> > +		}
> note that it sets flg2 to an absolute value. I just finished going
> through the code removing all of these. If you ever set flg2 to an
> absolute value then we cannot do unicode on the wire. If you wish to
> set a particular bit in flg2 then just set that bit - don't clobber
> all the other bits that have been carefully setup by other parts of
> the code.

Ah yes - and I should have realized why the 2.2 diff didn't
apply cleanly :-) :-). And I remember looking at your changes
thinking (yep, that's the right way to do it :-).

Ok - I'll be more careful forward porting to HEAD
in future.



Buying an operating system without source is like buying
a self-assembly Space Shuttle with no instructions.

More information about the samba-technical mailing list