PATCH Re: build failure: libsmb/clifile.c

Michael Gerdts Michael.Gerdts at usa.alcatel.com
Fri Jun 29 14:04:40 GMT 2001


On Fri, Jun 29, 2001 at 09:44:28AM -0400, Michael Gerdts wrote:
> On Solaris 8, CVS as of 2001/06/29 09:31 EDT:
> 
> Compiling libsmb/clifile.c
> libsmb/clifile.c: In function `cli_nt_create_full':
> libsmb/clifile.c:246: warning: passing arg 1 of `clistr_align' from
> incompatible pointer type
> libsmb/clifile.c:246: too few arguments to function `clistr_align'
> 
> clistr_align() seems to have forgotten the flags argument.
> 

The following patch puts clifile.c:246 back to how it was a couple days
ago.  Not only was it missing the flags argument, but argument 1 was of the
wrong type.

Mike

-------------- next part --------------
Index: libsmb/clifile.c
===================================================================
RCS file: /cvsroot/samba/source/libsmb/clifile.c,v
retrieving revision 1.1.8.12
diff -c -r1.1.8.12 clifile.c
*** libsmb/clifile.c	25 Jun 2001 17:04:45 -0000	1.1.8.12
--- libsmb/clifile.c	29 Jun 2001 13:57:16 -0000
***************
*** 243,249 ****
  
  	p = smb_buf(cli->outbuf);
  	/* this alignment and termination is critical for netapp filers. Don't change */
! 	p += clistr_align(cli->outbuf, p);
  	len = clistr_push(cli, p, fname, -1, STR_CONVERT);
  	p += len;
  	SSVAL(cli->outbuf,smb_ntcreate_NameLength, len);
--- 243,249 ----
  
  	p = smb_buf(cli->outbuf);
  	/* this alignment and termination is critical for netapp filers. Don't change */
! 	p += clistr_align(cli, p, STR_CONVERT);
  	len = clistr_push(cli, p, fname, -1, STR_CONVERT);
  	p += len;
  	SSVAL(cli->outbuf,smb_ntcreate_NameLength, len);


More information about the samba-technical mailing list