[bug] simple but severe coding bugs of rpcclient

[Tim Potter]

Samba-JP TAKAHASHI Motonobu writes:

> Hello
> 
> The following problem was found at Samba-JP, that the evaluation
> of rpc_api_pipe_req() return value is mistaken.
> 
> Please look at the patch in detail :-(
> 
> Here is a patch to fix it for Samba 2.0.9/Samba HEAD branch.
> 
> And there may be 2 other similar bug in cli_reg.c, bug we have not
> examined them.

The rpcclient program in 2.0/2.2 is pretty broken.  I've been
working on a new implementation, with the libsmb directory.  If
you run rpcclient out of HEAD you will get these functions rather
than the ones in the rpc_client directory.


Tim.