problems with acls

[Jan Strohbehn]

Hi !!

We had much problems changing acls from NT clients. The problem was,
that samba got invalid SIDs sometimes, and aborted with an "unable to map
sid" error.
The following patch solved our problem. Please tell me if there is sth.
wrong with that?!

Jan


--- samba/source/smbd/posix_acls.c	Tue Jun 12 03:49:36 2001
+++ samba_xfs/samba/source/smbd/posix_acls.c	Mon Jun 18 11:07:39 2001
@@ -739,13 +739,16 @@
 			current_ace->owner_type = GID_ACE;
 		} else {
 			fstring str;
-
-			free_canon_ace_list(file_ace);
-			free_canon_ace_list(dir_ace);
-			free(current_ace);
 			DEBUG(0,("create_canon_ace_lists: unable to map SID %s to uid or gid.\n",
 				sid_to_string(str, &current_ace->sid) ));
-			return False;
+			if (current_ace)
+			    free(current_ace);
+			continue;
 		}

 		/*