[prb] "default service" does not depend on "coding system"

[Samba-JP TAKAHASHI Motonobu]

Hello,

I found a problem under multibyte environment.
When we set a multibyte share name as "default service", we have to
write it in internal code (Shift JIS in Japanese) instead of unix code
set with "coding system" and "client code page".

To fix this, simply set FLAG_DOS_STRING attribute to "default service".

Here is a patch to fix this problem.

---- Cut Here ---- For 2.0.9 ----
diff -Nru samba-2.0.9.org/source/param/loadparm.c samba-2.0.9/source/param/loadparm.c
--- samba-2.0.9.org/source/param/loadparm.c	Sun Jun 17 10:49:45 2001
+++ samba-2.0.9/source/param/loadparm.c	Sun Jun 17 10:54:00 2001
@@ -828,8 +828,8 @@
   {"utmp hostname",    P_STRING,  P_GLOBAL, &Globals.szUtmpHostname,    NULL,   NULL,  0},
   {"utmp consolidate", P_BOOL,    P_GLOBAL, &Globals.bUtmpConsolidate,  NULL,   NULL,  0},
 #endif /* WITH_UTMP */
-  {"default service",  P_STRING,  P_GLOBAL, &Globals.szDefaultService,  NULL,   NULL,  0},
-  {"default",          P_STRING,  P_GLOBAL, &Globals.szDefaultService,  NULL,   NULL,  0},
+  {"default service",  P_STRING,  P_GLOBAL, &Globals.szDefaultService,  NULL,   NULL,  FLAG_DOS_STRING},
+  {"default",          P_STRING,  P_GLOBAL, &Globals.szDefaultService,  NULL,   NULL,  FLAG_DOS_STRING},
   {"message command",  P_STRING,  P_GLOBAL, &Globals.szMsgCommand,      NULL,   NULL,  0},
   {"dfree command",    P_STRING,  P_GLOBAL, &Globals.szDfree,           NULL,   NULL,  0},
   {"valid chars",      P_STRING,  P_GLOBAL, &Globals.szValidChars,      handle_valid_chars, NULL,  0},

---- Cut Here ---- For 2.2.0 ----
diff -Nru samba-2.2.0.org/source/param/loadparm.c samba-2.2.0/source/param/loadparm.c
--- samba-2.2.0.org/source/param/loadparm.c	Fri Apr 13 13:09:37 2001
+++ samba-2.2.0/source/param/loadparm.c	Sun Jun 17 10:40:02 2001
@@ -972,8 +972,8 @@
 #endif /* WITH_UTMP */
 	
 	{"default service", P_STRING, P_GLOBAL,
-	 &Globals.szDefaultService, NULL, NULL, 0},
-	{"default", P_STRING, P_GLOBAL, &Globals.szDefaultService, NULL, NULL, 0},
+	 &Globals.szDefaultService, NULL, NULL, FLAG_DOS_STRING},
+	{"default", P_STRING, P_GLOBAL, &Globals.szDefaultService, NULL, NULL, FLAG_DOS_STRING},
 	{"message command", P_STRING, P_GLOBAL, &Globals.szMsgCommand, NULL, NULL, 0},
 	{"dfree command", P_STRING, P_GLOBAL, &Globals.szDfree, NULL, NULL, 0},
 	{"valid chars", P_STRING, P_GLOBAL, &Globals.szValidChars, handle_valid_chars, NULL, 0},

-----
TAKAHASHI Motonobu                    mailto:monyo at samba.gr.jp
Samba Users Group Japan               http://www.samba.gr.jp/