Locking Worries

[Romeril, Alan]

Hi Jeremy,
	I gave it a try on the latest 2.2 CVS code, but the profile download
failed with Can`t copy  "...../desktop.ini" to
"C:\documents........./desktop.ini"  DETAIL Access is Denied... logging you
on with a temporary profile. 

I`ll sent the ethereal cap off the list...

Alan
	
p.s  Have you had chance to look at the Unicode bug I reported on the 18th?


-----Original Message-----
From: Jeremy Allison [mailto:jeremy at valinux.com]
Sent: 24 July 2001 02:20
To: Romeril, Alan; Samba technical; jeremy at valinux.com
Subject: Re: Locking Worries


Alan,

	I believe I've found the problem. Please apply
the following patch and test again the downloading of
profiles. We were making an assumption in the oplock
break code path that was invalid (ie. we were assuming
we could infer a non-levelII oplock when such an oplock
was detected - this may no longer be valid once we've
processed the break and we're going to iterate round
the loop again anyway).

See if this changes the behaviour.

Thanks,

	Jeremy.

Index: smbd/open.c
===================================================================
RCS file: /data/cvs/samba/source/smbd/open.c,v
retrieving revision 1.62.4.20
diff -u -r1.62.4.20 open.c
--- smbd/open.c 5 Jul 2001 23:37:07 -0000       1.62.4.20
+++ smbd/open.c 24 Jul 2001 01:11:16 -0000
@@ -514,7 +514,6 @@
         }
 
         broke_oplock = True;
-        *p_all_current_opens_are_level_II = False;
         break;
 
       } else if (!LEVEL_II_OPLOCK_TYPE(share_entry->op_type)) {
===================================================================

-- 
--------------------------------------------------------
Buying an operating system without source is like buying
a self-assembly Space Shuttle with no instructions.
--------------------------------------------------------