patch for User Manager for Domains on W2K
Jim McDonough
jmcd at us.ibm.com
Wed Feb 28 18:23:59 GMT 2001
On the current SAMBA_2_2 branch, when I do User Manager for domains on a
W2k machine, I get a SEGV in smbd, basically trying to marshall a unistring
(the machine or domain name) in the reply. srv_wkssvc_nt.c declares a
WKS_INFO_100 in _wks_query_info, and by the time we marshall the structure
in wks_io_wks_info_100 (in rpc_parse/parse_wks.c), the stack gets deep
enough to overwrite part of the original WKS_INFO_100 field, and the string
lengths get hosed up.
Here's my patch...just making it static...not sure if you want to allocate
one instead and free it after marshalling...
--- /samba/orig/samba-2.2/source/rpc_server/srv_wkssvc_nt.c Mon Feb 26
13:06:12 2001
+++ rpc_server/srv_wkssvc_nt.c Wed Feb 28 11:16:53 2001
@@ -62,7 +62,7 @@
uint32 _wks_query_info(pipes_struct *p, WKS_Q_QUERY_INFO *q_u,
WKS_R_QUERY_INFO *r_u)
{
- WKS_INFO_100 wks100;
+ static WKS_INFO_100 wks100;
DEBUG(5,("_wks_query_info: %d\n", __LINE__));
Jim
----------------------------
Jim McDonough
Linux Technology Center
IBM Boulder
Notes: Jim McDonough/Boulder/IBM @ IBMUS
VNET: JMCD at IBMUSM54
Internet: jmcd at us.ibm.com
Phone: (303) 924-5822
T/L: 263-5822
More information about the samba-technical
mailing list