Updating samr code...

[Jeremy Allison]

On Sat, Feb 17, 2001 at 11:23:09AM +0100, Jean Francois Micouleau wrote:

> yeah !
> 
> some remarks about win9x user list:
> 
> samba 2.2 enum_dom_groups should be renamed to samr_querydispinfo_2

Yep - I'd spotted this I think.

> You need to import from TNG:
> 
> enum_dom_groups: the real one, opcode is 0xB. But you will have to fake
> the group list.

Ok - can you give me more details here ?

> querydispinfo_4 to list the users, returns the list as ASCII strings.


> I have a netmon capture of a win98 getting the list from an NT4 server, if
> you need.

That might help - can you send it to me ?

> I can do the lsa code if you want. oh and btw, I've in my tree added
> policy handle managment to lsa.

I was going to do *all* of them (this also includes some changes
to the spoolss code). I'm hoping to get most of it done this weekend
at home.....

If you want to do the LSA one that's help a lot. I'll leave
that one until last then.

The idea is that all the '_XXXX' functions take 3 args,
1 - pipestruct, 2 - address of query struct parsed from packet,
3 - address of reply struct to be marshalled into packet.

Then inside the _XXX function we use the talloc context extracted
from the rdata prs_struct attached to the pipe handle to do all
mallocs as we create the reply struct.

That way all the memory goes away when we finish with the reply,
and we don't need those ugly free_XXX function calls scattered
everywhere on error, or in the top after the success case.

Jeremy.

-- 
--------------------------------------------------------
Buying an operating system without source is like buying
a self-assembly Space Shuttle with no instructions.
--------------------------------------------------------