sys_acl_add_perm

[Toomas Soome]

On Thu, 15 Feb 2001, Medha Date wrote:

> sys_acl_add_perm( SMB_ACL_PERMSET_T permset, SMB_ACL_PERM_T perm)
>
> Since it's necessary to change permset in sys_acl_add_perm, should the
> function parameters not be:
>
> sys_acl_add_perm( SMB_ACL_PERMSET_T *permset, SMB_ACL_PERM_T perm)
>
> And shouldn't functions that call sys_acl_add_perm, such as
> map_acl_perms_to_permset, send a pointer to the value of permset, instead of
> the value itself?
>
> I think I'm missing something obvious since posix acls and UNIXware ACLs
> don't seem to have a problem with this.
>


typedef struct __acl_permset_ext *acl_permset_t;

and

#define SMB_ACL_PERMSET_T           acl_permset_t

it seems to be pointer already.

the first typedef is from 'Linux Access Control Lists - User Library and
Utilities' by Andreas Gruenbacher, <a.gruenbacher at computer.org>.

toomas
-- 
The only thing to do with good advice is pass it on.
It is never any use to oneself.
		-- Oscar Wilde