set_filetime problem

[Simo Sorce]

you got it before me jeremy :-)
I also applied it to tree saturday and tested a bit, it seem ok.

On Sun, Dec 16, 2001 at 01:04:04PM -0800, Jeremy Allison wrote:
> On Sun, Dec 16, 2001 at 12:36:56PM +0100, Juergen Hasch wrote:
> > 
> > ------------------------------------------------------------------------------
> > 
> > I have the same problem here with current Samba_2_2 from CVS.
> > When I set the write cache size to > 0, the file dates are lost
> > when copying to a samba share.
> > The following patch seems to correct this behaviour:
> > 
> > --- reply.c.orig	Sun Dec 16 12:14:33 2001
> > +++ reply.c	Sun Dec 16 12:27:40 2001
> > @@ -2964,6 +2964,8 @@
> >  		 */
> >  		int close_err;
> > 
> > +		/* flush write cache before setting mtime */
> > +		flush_write_cache(fsp, WRITE_FLUSH);
> >  		/*
> >  		 * If there was a modify time outstanding,
> >  		 * try and set it here.
> > 
> > Should it be done differently ?
> 
> Yes - good catch. I've just fixed this in HEAD and SAMBA_2_2
> CVS. Please check out and test it.
> 
> Thanks !
> 
> Jeremy.
> 

-- 
Simo Sorce       idra at samba.org
-------------------------------
Samba Team http://www.samba.org