[PATCH] pam_smbpass for CVS HEAD

Steve Langasek vorlon at netexpress.net
Tue Dec 11 11:56:14 GMT 2001

On Tue, Dec 11, 2001 at 08:54:30PM +0200, Alexander Bokovoy wrote:
> Attached patch makes pam_smbpass compileable again in CVS HEAD.
> I suspect that nobody uses pam_smbpass 'cause some of these problems
> exist in SAMBA_2_2 branch as well for a while... But fixing it is
> important as well.

Well, or perhaps no one that uses pam_smbpass spends a lot of time in
the HEAD branch. :)  I don't do a lot of constant tweaking w/
pam_smbpass, because very little changes in that code except to keep it
up-to-date with the current Samba branch for the purpose of /compiling/;
for /running/, you can just as well use pam_smbpass compiled against
Samba 2.0.7, and unless you need something cutting-edge like LDAP or tdb
storage, it'll interoperate fine with whatever version of Samba is on
the server.

BTW, in your patch I noticed that you've removed the xstrdup()
function... I believe in the SAMBA_2_2 branch, this function has been
renamed, not removed -- if the xstrdup() function that's common to Samba
is less paranoid than the one in pam_smbpass, this would seem
appropriate to do for CVS HEAD, as well.

Steve Langasek
postmodern programmer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 232 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20011211/eabc3941/attachment.bin

More information about the samba-technical mailing list