Samba i18n patches

[Rafal Szczesniak]

On Tue, 14 Aug 2001, TAKAHASHI Motonobu wrote:

> The default manpages should be stored in /usr/man/{man1,man3,...}.
> So, replaced "en" to ".", you can install manpages in default location
> of Samba archive(docs/manpages/*) to the default location of system
> manpages (i.e. /usr/man).
>
> >Existing shortcomings of this implementation:
> > 1) List of available languages is not generated
> >    automatically i.e. by probing docs/manpages/ contents
>
> Ok.
>
> > 2) Language specifiers (given by user) are not validated.
>
> It is better to check specified source directory
> (i.e. docs/manpages/ja) does not exists, I think.

Exactly. By checking source directories I want to fix the
above two.

> >It's been tested using man -L <locale> <manpage>. Didn't
> >properly configure system locale, yet.
>
> It works.

Great.

>
> >feedbacks are, of course, welcome
>
> - comma delimiter (--with-manpages-langs="ja,en") does not work but
>   space delimiter works.

Did you specify it as
--with-manpages-langs="ja,en"
or
--with-manpages-langs=ja,en
?

>
> - This is important. For future i18n expansion, storing resource like
>   manpages/{en,ja, ... } is not good. In my experience storing
>   ja/{manpages,htmldocs, ...}, pl/{manpages, htmldocs, ...}
>   ./{manpages, htmldocs} is better.

That's simple to correct.

>
>   In the latter way we can separate resources of each language version
>   easily.
>
>   Of course it's a design matter. Your way also works well.
>
> |-ALL_LINGUAS="en ja"
> |+ALL_LINGUAS="en ja pl"
>
> This change is concerned with gettext(), has nothing to do with
> installing manpages. please make source/po/pl.po to work the change:-)

Yes, I know. First I forgot to sent it with patches. Then
I've noticed something needs correction. Will be available
quite soon.

>
> And I think syncronizing ALL_LINGUAS and installing manpage is better.

That was my first version. But I thought you might use for
something different, yet. Besides I didn't want suddenly
move it through the code just because I need it to be
defined somewhat earlier.
BTW. Does ALL_LINGUAS mean something different than
ALL_LANGS ?

>
>
>
> The following patch is to modify configure.in as I said.
>
> --- configure.in        Tue Aug 14 23:28:25 2001
> +++ configure.in.new    Tue Aug 14 23:14:45 2001
> @@ -2081,10 +2081,10 @@
>  [ case "$withval" in
>    yes|no)
>      AC_MSG_WARN(--with-manpages-langs called without argument - will
> use default)
> -    manlangs="en"
> +    manlangs="."
>    ;;
>    *)
> -    manlangs="$withval"
> +    manlangs=". $withval"
>    ;;
>    esac
>
> @@ -2092,7 +2092,7 @@
>    manlangs=${manlangs//,/ }
>    AC_SUBST(manlangs)],
>
> -  [manlangs="en"
> +  [manlangs="."
>    AC_MSG_RESULT($manlangs)
>    AC_SUBST(manlangs)]
>  )
>

I still couldn't configure SWAT to make use of locales
although I don't give up quickly :)
cheers,

Rafal 'Mimir' Szczesniak <mimir at spin.ict.pwr.wroc.pl>   |
*BSD, Linux and Samba                                  /
______________________________________________________/