Another malloc without NULL check

Tim Potter tpot at
Mon Aug 6 23:33:41 GMT 2001

Claudia Moroder writes:

> Hello Tim,
> it is effectively
> if (!cli->outbuf || !cli->inbuf)
> {
> return NULL;
> but IMHO your cleanup continues to leave around memory.
> it should be, because maybe that cli was also malloced a few lines before
> and gets lost if we return NULL.
> But... the problem is that cli is passed and is malloced only if NULL is
> passed.

Whoops - didn't see that one.  I've checked in another fix.



More information about the samba-technical mailing list