nmbd INTERNAL ERROR in 2.2.0

[Jeremy Allison]

PetitBilouch at netscape.net wrote:
> 
> Hi,
> 
> nmbd has stopped to work properly for me and rashes consistently a fews
> minutes after started. My system is Ultra1/Solaris 5.5.1.
> 
> Here is a backtrae of the nmbd process:
> 
> (gdb) backtrace
> #0  0xef5be914 in waitid () from /usr/lib/libc.so.1
> #1  0xef5e2838 in _waitpid () from /usr/lib/libc.so.1
> #2  0xef5f608c in system () from /usr/lib/libc.so.1
> #3  0x5a6e0 in smb_panic (why=0x79b20 "internal error") at lib/util.c:1137
> #4  0x47918 in fault_report (sig=11) at lib/fault.c:45
> #5  0x4796c in sig_fault (sig=11) at lib/fault.c:65
> #6  <signal handler called>
> #7  0x1d59c in debug_browse_data (outbuf=0xe22de "\001\001 »\r", len=25912) at nmbd/nmbd_packets.c:110
> #8  0x1ed10 in process_browse_packet (p=0xe2190, buf=0xe22de "\001\001 »\r", len=25912) at nmbd/nmbd_packets.c:1071
> #9  0x1f474 in process_dgram (p=0xe2190) at nmbd/nmbd_packets.c:1277
> #10 0x1febc in run_packet_queue () at nmbd/nmbd_packets.c:1611
> #11 0x13014 in process () at nmbd/nmbd.c:347
> #12 0x13db0 in main (argc=1, argv=0xeffffec4) at nmbd/nmbd.c:866

Well spotted ! Here's a patch for this. It'll be in 2.2.1.

Thanks a *LOT* for that backtrace !

Cheers,

	Jeremy Allison,
	Samba Team.

Index: nmbd/nmbd_packets.c
===================================================================
RCS file: /data/cvs/samba/source/nmbd/nmbd_packets.c,v
retrieving revision 1.40.2.2
diff -u -r1.40.2.2 nmbd_packets.c
--- nmbd/nmbd_packets.c 2001/01/08 20:37:45     1.40.2.2
+++ nmbd/nmbd_packets.c 2001/04/24 18:00:41
@@ -107,12 +107,14 @@

     for (j = 0; j < 16; j++)
     {
-      unsigned char x = outbuf[i+j];
+      unsigned char x;
+      if (i+j >= len)
+        break;
+
+      x = outbuf[i+j];
       if (x < 32 || x > 127)
         x = '.';

-      if (i+j >= len)
-        break;
       DEBUGADD( 4, ( "%c", x ) );
     }
-- 
--------------------------------------------------------
Buying an operating system without source is like buying
a self-assembly Space Shuttle with no instructions.
--------------------------------------------------------