Self-check patches for 2.2.0 alpha 3

David Collier-Brown davecb at canada.sun.com
Thu Apr 12 11:46:02 GMT 2001


Makis Marmaridis wrote:
> +   /* Implausible overrides and missing prerequisites: WARNINGs. */
> +   /* If a service is flagged unavailable, log the fact at level 0. */
> +   if (!s->bAvailable) {
> +      DEBUG(1,( "NOTICE: Service [%s] is marked available = no.\n",
> +            s->szService));
> 
> The comments says log this at level 0 but the code has DEBUG(1,...
> Is this correct or am I not making any sense here? Please let me know.

	Yup, that's an obvious error, as was the "ned". Thanks!

	Samba-team, the above line in the patch is in error, as 
	is the line that says "We ned oplocks"

--dave
-- 
David Collier-Brown,           | Always do right. This will gratify 
Performance & Engineering Team | some people and astonish the rest.
Americas Customer Engineering  |                      -- Mark Twain
(905) 415-2849                 | davecb at canada.sun.com




More information about the samba-technical mailing list