Buglets and booby-traps in Samba 2.2.0 beta 3

[Tim Potter]

David Collier-Brown writes:

>    There are lots of duplicated definitions, some between nterr.h
> and smb.h, which have to be kept in sync or mysterious errors will 
> occur, the very thing one used defines to avoid! 
> 
> For example:
> ./include/smb.h:#define Auto (2)
> ./nsswitch/winbind_nss_config.h:#define Auto (2)

> ./include/smb.h:#define _PSTRING
> ./nsswitch/winbind_nss_config.h:#define _PSTRING

> ./include/smb_macros.h:#define ZERO_STRUCT(x) memset((char *)&(x), 0,
> sizeof(x!
> ./nsswitch/winbind_nss_config.h:#define ZERO_STRUCT(x) memset((char
> *)&(x), 0,!

The winbind_nss_config.h is meant to be a replacement for the
whole includes.h business.  There are too many header file
dependencies if you include *.h.  I thought there was a comment
in winbind_nss_config.h to this effect.

The rest of the examples are bugs though.  (-:


Tim.