configure.in change

samba-technical at thewrittenword.com samba-technical at thewrittenword.com
Wed Apr 11 03:49:59 GMT 2001


On Tue, Apr 10, 2001 at 06:51:08PM -0700, Herbert Lewis wrote:
> samba-technical at thewrittenword.com wrote:
> > 
> > Ick! And how does someone compile with -O2? I would recommend leaving
> > CFLAGS alone if it is set at all:
> >   test "${CFLAGS+set}" != set && CFLAGS="-O ${CFLAGS}"
> > 
> > --
> > albert chin (china at thewrittenword.com)
> 
> Thats why I did a prepend. Most compilers will take the last of
> conflicting values so if you specify -O and -O3 it will use -O3

I still disagree with the solution. Why touch CFLAGS at all if
someone already has it set? If someone sets CFLAGS, I think we
should believe they know what they are doing.

-- 
albert chin (china at thewrittenword.com)




More information about the samba-technical mailing list