[PATCH] Various Netlogon stuff

[Gerald Carter]

Thanks Andrwe,

comment inline...

On Mon, 09 Apr 2001 07:33:38 Andrew Bartlett wrote:
>
> Index: source/passdb/smbpass.c
> ===================================================================
> RCS file: /cvsroot/samba/source/passdb/Attic/smbpass.c,v
> retrieving revision 1.102.4.4
> diff -u -d -r1.102.4.4 smbpass.c
> --- source/passdb/smbpass.c	2001/03/27
> 00:05:25	1.102.4.4
> +++ source/passdb/smbpass.c	2001/04/09 12:01:25
> @@ -472,6 +526,14 @@
>  		user.group_rid = pdb_gid_to_group_rid(user.smb_grpid
> );
>  
>  		pstrcpy(full_name    , pwfile->pw_gecos        );
> +
> +		if (lp_unix_realname())
> +		{
> +		  fstrcpy(full_name, strtok(full_name, ","));
> +		} else {
> +		  fstrcpy(full_name, "<Full Name>");
> +		}
> +
>  		pstrcpy(logon_script , lp_logon_script       ());
>  		pstrcpy(profile_path , lp_logon_path         ());
>  		pstrcpy(home_drive   , lp_logon_drive        ());

Done.


> Index: source/rpc_server/srv_netlog_nt.c
> ===================================================================
> RCS file: /cvsroot/samba/source/rpc_server/srv_netlog_nt.c,v
> retrieving revision 1.1.2.6
> diff -u -d -r1.1.2.6 srv_netlog_nt.c
> --- source/rpc_server/srv_netlog_nt.c	2001/04/07
> 05:05:23	1.1.2.6
> +++ source/rpc_server/srv_netlog_nt.c	2001/04/09 12:01:25
> @@ -421,7 +499,7 @@
>  		if(smb_password_check((char *)id2->nt_chal_resp.buffer,
>  		                   smb_pass->smb_nt_passwd,
>                             id2->lm_chal)) 
> -			return 0x0;
> +			return NT_STATUS_NOPROBLEMO;
>  		else
>  			return NT_STATUS_WRONG_PASSWORD;
>  	}
> @@ -439,10 +517,9 @@
>  		                   smb_pass->smb_passwd,
>  		                   id2->lm_chal))
>  	{
> -		return 0x0;
> +		return NT_STATUS_NOPROBLEMO;
>  	}
>  
> -
>  	/* oops! neither password check succeeded */
>  
>  	return NT_STATUS_WRONG_PASSWORD;

Done.

> @@ -561,16 +634,11 @@
> -		/* XXXX hack to get standard_sub_basic() to use sam
> logon username */
> -		/* possibly a better way would be to do a
> become_user() call */
> -		sam_logon_in_ssb = True;
> -		pstrcpy(samlogon_user, nt_username);

This line needs to stay or the %U expansion for profile
settings, logon_home, etc...won't work.  See Luke's comment
listed above.

The rest looks ok.






Cheers, jerry
----------------------------------------------------------------------
   /\  Gerald (Jerry) Carter                     Professional Services
 \/    http://www.valinux.com/  VA Linux Systems   gcarter at valinux.com
       http://www.samba.org/       SAMBA Team          jerry at samba.org
       http://www.plainjoe.org/                     jerry at plainjoe.org

       "...a hundred billion castaways looking for a home."
                                - Sting "Message in a Bottle" ( 1979 )