[PATCH] segfault (attempt to dereference/free null) in smbd/service.c -- 2.0.7 and 2.2.0-alpha

[Jeremy Allison]

Ed Boraas wrote:
> 
> The client in question is an NT4 Terminal Server, with a large number of
> concurrent users. After the smbd dies, various Bad Things(tm) occur,
> including document corruption and the like. After a brief investigation, I
> believe the following patch should prevent the segfault:
> 
> [begin patch]
> --- samba-2.0.7.old/source/smbd/service.c       Tue Apr 25 17:07:12 2000
> +++ samba-2.0.7.new/source/smbd/service.c       Fri Apr  6 12:06:24 2001
> @@ -290,7 +290,6 @@
>         if (!conn) {
>                 DEBUG(0,("Couldn't find free connection.\n"));
>                 *ecode = ERRnoresource;
> -               conn_free(conn);
>                 return NULL;
>         }
> [end patch]

Thanks a *lot* for that. I've applied it to HEAD and 2.2.

Jeremy.

-- 
--------------------------------------------------------
Buying an operating system without source is like buying
a self-assembly Space Shuttle with no instructions.
--------------------------------------------------------