bug in configure.in

Jeremy Allison jeremy at valinux.com
Tue Apr 3 15:39:22 GMT 2001


Gerald Carter wrote:
> 
> On Mon, 2 Apr 2001, Herb Lewis wrote:
> 
> > The following lines exist in configure.in and contain a bug. I'm not
> > sure of the original intent so I hesitate to change it. If you have
> > a value set for CFLAGS, this code in effect duplicates the contents.
> 
> I wondered about that :-)
> 
> > Who made this change and what was the intention?
> 
> No I, but see below....
> 
> > # compile with optimization and without debugging by default
> > OPTIM=${CFLAGS-"-O"}
> >
> > AC_ARG_ENABLE(debug, [  --enable-debug        turn on debugging
> > [default=no]],
> >     [if eval "test x$enable_debug = xyes"; then
> >         OPTIM="-g"
> >     fi])
> >
> > CFLAGS="${CFLAGS:=} $OPTIM"
> >
> 
> I think the option was to enable debug flags without having to do things
> like
>         env CFLAGS="-g -Wall" ./configure
> 
> I'm guessing it was patched in around the same time as the --with-fhs
> flag maybe>?

My problem for not spotting it in the original patch, sorry.

I'll look at fixing it (help welcome :-).

Jeremy.

-- 
--------------------------------------------------------
Buying an operating system without source is like buying
a self-assembly Space Shuttle with no instructions.
--------------------------------------------------------




More information about the samba-technical mailing list