Possible "kernel oplock" bugs on Solaris 8

[David Collier-Brown]

  In a discussion with Herb Lewis of SGI, I noticed an unlikely
message in my logs, indicating a possible samba bug. This is 
addition of testparm thinking that I had kernel oplocks!
(Dbx confirms I don't).

  I had set kernel oplocks = true, so as to test that it
would fail on Solaris, which lacks kernel oplocks.  Alas,
when I looked at the logs, I had
---
[2000/09/21 09:28:43, 2] smbd/server.c:(746)
  Changed root to /
[2000/09/21 09:28:43, 3] smbd/oplock.c:(86)
  open_oplock_ipc: opening loopback UDP socket.
[2000/09/21 09:28:43, 3] lib/util_sock.c:(875)
  bind succeeded on port 0
[2000/09/21 09:28:43, 3] smbd/oplock.c:(114)
  open_oplock ipc: pid = 802, global_oplock_port = 33656
---

  Looking at open_oplock in smbd/oplock.c, I see the last
message comes **after** a success return from 
setup_kernel_oplock_pipe(),due to HAVE_KERNEL_OPLOCKS being undefined.

  This looks backwards: if I don't have kernel oplocks, I
shouldn't be opening port 33656 to get port scans on!
  I tentatively reccomend
---
#endif /* HAVE_KERNEL_OPLOCKS */
  return False;
}
---
in oplock.c, line 74.


--dave
-- 
David Collier-Brown,  | Always do right. This will gratify some people
185 Ellerslie Ave.,   | and astonish the rest.        -- Mark Twain
Willowdale, Ontario   | //www.oreilly.com/catalog/samba/author.html
Work: (905) 415-2849 Home: (416) 223-8968 Email: davecb at canada.sun.com