[PATCH] RFC: shell-safe version of string_sub()?

Nicolas Williams Nicolas.Williams at ubsw.com
Mon Oct 23 19:11:50 GMT 2000


[Once again, I'm breaking threading -- gimme Message-Id headers! :) ]

Very, very cool.

I like this very much. Especially since I'll be using Andy Bakun's
open_command/close_command patch and, for obvious security reasons, I'd
like to use this patch.

However: the printing/printing.c patch did not apply to 2.0.7 at all.

There's no code in 2.0.7's source/printing/printing.c that even remotely
resembles the code in the context provided by the diff -u patch you
sent.

Hmmm, doh! I just re-read your post. The patch was against the
SAMBA_2_2 branch.

Never mind. But I am very grateful as this patch is very good, from a
security point of view.

Hmmm, what about unicode/code pages? Will this patch work as intended?

Nico
--





More information about the samba-technical mailing list