bug in params.c

Teemu Junnila (QRA) Teemu.Junnila at era.ericsson.se
Tue Oct 17 06:58:44 GMT 2000


No!
If you AND the char wih 7F you just drop the eight bit, like ÅÄÖ -> EDV

/Teemu

-----Original Message-----
From: Robert Dahlem [mailto:Robert.Dahlem at gmx.net]
Sent: den 17 oktober 2000 00:11
To: Christopher R. Hertel
Cc: samba-technical at samba.org
Subject: Re: bug in params.c


Chris,

On Mon, 16 Oct 2000 11:27:26 -0500 (CDT), Christopher R. Hertel wrote:

>>         /* be sure to return chars >127 as positive values */
>>       return (int)( *(f->p++) & 0x00FF );

Shouldn't this be

    return (int)( *(f->p++) & 0x007F );

?

Regards,
        Robert


-- 
---------------------------------------------------------------
Robert.Dahlem at gmx.net           Fax +49-69-432647
---------------------------------------------------------------

Sent using PMMail (http://www.pmmail2000.com) - fast, decent, email
software; far better than Outlook. Try it sometime.






More information about the samba-technical mailing list