CVS update: samba/source/passdb

[Jeremy Allison]

Tim Potter wrote:
> 
> Gerald Carter writes:
> 
> > This is actually a big performance hit.  Tim, we need to
> > revist the dependencies here.  Look at
> > construct_default_printer_sdb()
> >
> > if (!lookup_name( "Printer Administrators", &owner_sid, &name_type) &&
> >       !lookup_name( "Administrators", &owner_sid, &name_type) &&
> >       !lookup_name( "Administrator", &owner_sid, &name_type) &&
> >       !lookup_name("root", &owner_sid, &name_type)) {
> >               sid_copy(&owner_sid, &global_sid_World);
> >       }
> > }
> 
> Eeek!  This is not the correct way to look up names as it isn't
> portable across non-English NT machines - just ask Mr JF
> Administrateur about it.  (-:

This from the man who *ingored* I18N in winbindd !!!!

:-) :-).
 
> The correct way (which also indirectly solves this lookup
> problem) is to construct a sid using global_sam_sid and append a
> well known RID value from rpc_misc.h:
> 
> DOMAIN_USER_RID_ADMIN for the administrator user
> DOMAIN_GROUP_RID_ADMINS for the Administrators group

True - the current code was a temporary hack that needs fixing.

Jeremy.

-- 
--------------------------------------------------------
Buying an operating system without source is like buying
a self-assembly Space Shuttle with no instructions.
--------------------------------------------------------