CVS update: samba/source/passdb

[Gerald Carter]

Richard Sharpe wrote:
> 
> Date:   Monday November 27, 2000 @ 13:44
> Author: sharpe
> 
> Update of /data/cvs/samba/source/passdb
> In directory samba:/tmp/cvs-serv14223
> 
> Modified Files:
>       Tag: SAMBA_2_2
>         passdb.c
> Log Message:
> Ensure that we call Get_Pwnam so that workstation account 
> names are mapped to the correct case!
> 
> Otherwise the doco has to change ...

Richard,

This is actually a big performance hit.  Tim, we need to 
revist the dependencies here.  Look at 
construct_default_printer_sdb() 

if (!lookup_name( "Printer Administrators", &owner_sid, &name_type) &&
	!lookup_name( "Administrators", &owner_sid, &name_type) &&
	!lookup_name( "Administrator", &owner_sid, &name_type) &&
	!lookup_name("root", &owner_sid, &name_type)) {
		sid_copy(&owner_sid, &global_sid_World);
	}
}

This code (indirectly using local_lookup_name()) was making 
it impossible to print.  I had a LDAP server providing about 
6,000 accounts.  Simply trying to look at the printer
properties was impossible because of the getpwnam() calls.
local_lookup_name() need to use sys_getpwnam().  We should 
deal with machine accounts, but using Get_Pwnam() in 
local_lookup_name() has some fairly large implications.


I'm open to suggestions, but I am really buried this week.






Cheers, jerry
----------------------------------------------------------------------
   /\  Gerald (Jerry) Carter                     Professional Services
 \/    http://www.valinux.com/  VA Linux Systems   gcarter at valinux.com
       http://www.samba.org/       SAMBA Team          jerry at samba.org
       http://www.plainjoe.org/                     jerry at plainjoe.org

       "...a hundred billion castaways looking for a home."
                                - Sting "Message in a Bottle" ( 1979 )